Conversation
Give Heroicon trigger glyphs explicit h-full/w-full (matching MiniMap) so they render inside the node on Safari, and stack adaptor-docs COPY/ADD controls above the example pre. Closes OpenFn#2960
b-pm
force-pushed
the
fix/2960-safari-css-trigger-docs
branch
from
September 9, 2026 12:07
746d154 to
86b93de
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, consistent with existing icon sizing patterns (e.g., MiniMap), and directly address the reported Safari rendering/clickability issues without altering business logic.
Pull request overview
This PR addresses Safari-specific UI issues in the workflow canvas and adaptor docs panel by ensuring SVG trigger icons reliably fill their intended slots and by fixing a stacking order problem that made docs actions unclickable in Safari.
Changes:
- Set trigger node Heroicons (
GlobeAltIcon,ClockIcon) toh-full w-fullso they size correctly within the absolutely positioned icon container. - Add an explicit layering setup (
relative+z-*) so adaptor docs COPY/ADD buttons render above example<pre>blocks on Safari. - Document the Safari fixes in the Unreleased changelog.
File summaries
| File | Description |
|---|---|
| CHANGELOG.md | Adds an Unreleased “Fixed” entry documenting the Safari icon sizing and adaptor-docs stacking fix. |
| assets/js/workflow-diagram/nodes/Trigger.tsx | Applies h-full w-full to trigger icons to ensure they fill the node icon slot (matching existing MiniMap behavior). |
| assets/js/adaptor-docs/components/render/Function.tsx | Adjusts stacking order with position: relative and z-index utility classes so COPY/ADD controls remain clickable above the example block. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
Gentle re-review ping — Safari trigger-icon + docs COPY/ADD stacking fix is green on CircleCI. Happy to adjust if anything else is needed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Safari UI issues on the workflow canvas and adaptor docs panel.
Closes #2960
GlobeAltIcon/ClockIcon) now useh-full w-full, matching MiniMap, so Safari sizes the SVG inside the absolutely positioned slot<pre>Validation steps
AI Usage
Pre-submission checklist